Expose CreatePollScreen and fix state restoration
#5958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size Comparison 📏
|
…l_screen_and_fix_state_restoration
VelikovPetar
changed the title
CreatePollScreen and fix state restoration.CreatePollScreen and fix state restoration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the CreatePollScreen composable as a standalone component and fixes state restoration issues for poll creation across orientation changes.
- Extracts
CreatePollScreenfrom the attachment picker factory into a standalone composable - Implements a
CreatePollViewModelwith proper state management for configuration preservation - Adds visual improvements by highlighting selected tab icons for Poll and Location attachments
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CreatePollScreen.kt | New standalone composable extracted from attachment picker factory |
| CreatePollViewModel.kt | New ViewModel handling poll creation state with proper lifecycle management |
| CreatePollViewModelTest.kt | Comprehensive test suite for the new ViewModel |
| CreatePollViewModelFactory.kt | Factory for creating ViewModel instances with configuration switches |
| AttachmentsPickerPollTabFactory.kt | Refactored to use the new CreatePollScreen composable |
| AttachmentsPicker.kt | Updated to use ViewModel state instead of local remember state |
| LocationPickerTabFactory.kt | Added highlighted icon for selected state |
| stream-chat-android-compose.api | API surface addition for the new public CreatePollScreen function |
| CHANGELOG.md | Documentation of the new feature and bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...n/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/CreatePollViewModel.kt
Show resolved
Hide resolved
...n/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/CreatePollViewModel.kt
Show resolved
Hide resolved
...src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/AttachmentsPicker.kt
Show resolved
Hide resolved
…reate_poll_screen_and_fix_state_restoration' into feature/AND-831_AND_832_expose_create_poll_screen_and_fix_state_restoration
…l_screen_and_fix_state_restoration # Conflicts: # CHANGELOG.md
…l_screen_and_fix_state_restoration # Conflicts: # CHANGELOG.md
|
VelikovPetar
deleted the
feature/AND-831_AND_832_expose_create_poll_screen_and_fix_state_restoration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
CreatePollScreenso that it can used independently from theAttachmentsPickerPollTabFactory🛠 Implementation details
CreatePollScreenas a standalone composableCreatePollViewModeland move all state management fromCreatePollScreento theViewModelAttachmentsPickercomposable: Now reads the selected state from the viewModel instead of usingrememberPollandLocationattachments🎨 UI Changes
before.mp4
after.mp4
🧪 Testing
Polltab